Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[miele] Migrate time channels from DateTime to Number:Time #13841

Merged
merged 1 commit into from
Dec 10, 2022

Conversation

jlaur
Copy link
Contributor

@jlaur jlaur commented Dec 4, 2022

Migrate channels duration, elapsed and finish from DateTime to Number:Time since they represent an amount of time, not a specific point in time.

This is a breaking change requiring UI things to be recreated and linked items for these channels to be recreated. Persistence of these channels is unlikely, but would also break. Rules would need adaptation. Therefore I will provide a note in openhab-distro. After recreation of items, the default display format is the same, so UI's should be unaffected. openhab/openhab-distro#1435 prepared.

See also #13316 where related channels were fixed to represent a point in time.

Additional details are available in the linked issue.

Fixes #13840

Fixes openhab#13840

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
@jlaur jlaur marked this pull request as ready for review December 10, 2022 10:49
@jlaur jlaur requested a review from kgoderis as a code owner December 10, 2022 10:49
@jlaur jlaur added enhancement An enhancement or new feature for an existing add-on (potentially) not backward compatible labels Dec 10, 2022
@jlaur jlaur requested a review from a team December 10, 2022 11:28
Copy link
Member

@kaikreuzer kaikreuzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm and makes sense to fix even though it is a breaking change.

@kaikreuzer kaikreuzer merged commit c09be1b into openhab:main Dec 10, 2022
@kaikreuzer kaikreuzer added this to the 3.4 milestone Dec 10, 2022
@jlaur jlaur deleted the 13840-miele-simplify-time-channels branch December 12, 2022 21:57
morph166955 pushed a commit to morph166955/openhab-addons that referenced this pull request Dec 18, 2022
Fixes openhab#13840

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
Signed-off-by: Ben Rosenblum <rosenblumb@gmail.com>
andrasU pushed a commit to andrasU/openhab-addons that referenced this pull request Dec 24, 2022
Fixes openhab#13840

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/display-elapsed-time-seconds-to-hhss/142572/4

borazslo pushed a commit to borazslo/openhab-mideaac-addon that referenced this pull request Jan 8, 2023
Fixes openhab#13840

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
psmedley pushed a commit to psmedley/openhab-addons that referenced this pull request Feb 23, 2023
Fixes openhab#13840

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Feb 28, 2023
Fixes openhab#13840

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
andrasU pushed a commit to andrasU/openhab-addons that referenced this pull request Jan 6, 2024
Fixes openhab#13840

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on (potentially) not backward compatible
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[miele] Migrate time channels from DateTime to Number:Time
3 participants