-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[miele] Migrate time channels from DateTime to Number:Time #13841
Merged
kaikreuzer
merged 1 commit into
openhab:main
from
jlaur:13840-miele-simplify-time-channels
Dec 10, 2022
Merged
[miele] Migrate time channels from DateTime to Number:Time #13841
kaikreuzer
merged 1 commit into
openhab:main
from
jlaur:13840-miele-simplify-time-channels
Dec 10, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes openhab#13840 Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
jlaur
added
enhancement
An enhancement or new feature for an existing add-on
(potentially) not backward compatible
labels
Dec 10, 2022
kaikreuzer
approved these changes
Dec 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm and makes sense to fix even though it is a breaking change.
morph166955
pushed a commit
to morph166955/openhab-addons
that referenced
this pull request
Dec 18, 2022
Fixes openhab#13840 Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk> Signed-off-by: Ben Rosenblum <rosenblumb@gmail.com>
andrasU
pushed a commit
to andrasU/openhab-addons
that referenced
this pull request
Dec 24, 2022
Fixes openhab#13840 Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk> Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/display-elapsed-time-seconds-to-hhss/142572/4 |
borazslo
pushed a commit
to borazslo/openhab-mideaac-addon
that referenced
this pull request
Jan 8, 2023
Fixes openhab#13840 Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
psmedley
pushed a commit
to psmedley/openhab-addons
that referenced
this pull request
Feb 23, 2023
Fixes openhab#13840 Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
nemerdaud
pushed a commit
to nemerdaud/openhab-addons
that referenced
this pull request
Feb 28, 2023
Fixes openhab#13840 Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
andrasU
pushed a commit
to andrasU/openhab-addons
that referenced
this pull request
Jan 6, 2024
Fixes openhab#13840 Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk> Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
An enhancement or new feature for an existing add-on
(potentially) not backward compatible
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate channels duration, elapsed and finish from
DateTime
toNumber:Time
since they represent an amount of time, not a specific point in time.This is a breaking change requiring UI things to be recreated and linked items for these channels to be recreated. Persistence of these channels is unlikely, but would also break. Rules would need adaptation. Therefore I will provide a note in openhab-distro. After recreation of items, the default display format is the same, so UI's should be unaffected. openhab/openhab-distro#1435 prepared.
See also #13316 where related channels were fixed to represent a point in time.
Additional details are available in the linked issue.
Fixes #13840